search

dojo-sim / Dojo.jl

A differentiable physics engine for robotics
MIT License
297 stars 26 forks source link

Don't shadow `Base` functions #4

Closed rejuvyesh closed 2 years ago

rejuvyesh commented 2 years ago

We should be extending Base.step and Base.reset (I'm on Julia v1.7.2). I would recommend Squash and Merge for this PR because I accidentally added and reverted a local thing I was testing.

rejuvyesh commented 2 years ago

Also would be great if you could change your security settings to allow my (and other contributors') PRs to run CI!

simon-lc commented 2 years ago

Thanks for your help!

simon-lc commented 2 years ago

@rejuvyesh Hi Jayesh, I am sorry I am very new to this, we have this setting for the contributors' PRs: Screenshot from 2022-03-07 15-22-37 I am not sure but we had a check in CI.yml that might have prevented CI to test your PR. I removed it so hopefully this make things easier on your side! Please tell me if I need to do anything else to ease the process

rejuvyesh commented 2 years ago

I think changing it to require approval for "first-time contributors who are new to GitHub" is the recommended option. This way most accounts that have been using GitHub for a while, when they make a PR, should be able to have CI run for their PR as well. But just for me, your selected option is fine too!

simon-lc commented 2 years ago

Thanks for the explanation! I've just made the change