dojo / cli-build-app

Command for building Dojo applications
Other
9 stars 32 forks source link

Command exits when using watch or serve #407

Closed tomdye closed 4 years ago

tomdye commented 4 years ago

Bug

Package Version: 7.0.1

Expected behavior:

When using watch or serve, the command should continue to run after the first build

Actual behavior:

The command exits after the first build has completed

tomdye commented 4 years ago

Notes from initial discovery:

since we added the process.exit(0) on cli, the cli-build-app command resolves the command promise wrongly when it runs watch or serve. This causes the command to exit without serving or watching. If you remove the resolve() calls from serve it's all good, BUT, plot twist, the watch command needs to resolve for the serve, but not for the main watch command.