search

dojo / cli-build-webpack

🚀 **DEPRECATED** Dojo 2 - cli command for building applications
http://dojo.io
Other
4 stars 19 forks source link

CoreLoadPlugin: add option to map all app mids. #120

Closed mwistrand closed 7 years ago

mwistrand commented 7 years ago

Type: bug

The following has been addressed in the PR:

Description:

Introduce a flag (set within the webpack config to true when args.withTests is true) to CoreLoadPlugin that allows all app modules to be added to the internal mid map, so that they can be lazy-loaded without parsing, as long as the modules have already been loaded by webpack.

Resolves #106

codecov[bot] commented 7 years ago

Codecov Report

Merging #120 into master will increase coverage by 0.39%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
+ Coverage   95.59%   95.99%   +0.39%     
==========================================
  Files          11       11              
  Lines         613      624      +11     
  Branches      127      130       +3     
==========================================
+ Hits          586      599      +13     
+ Misses         14       13       -1     
+ Partials       13       12       -1
Impacted Files Coverage Δ
src/plugins/CoreLoadPlugin.ts 97.87% <100%> (+1.71%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 18ee79e...05ad572. Read the comment docs.