dojo / cli-build-webpack

🚀 **DEPRECATED** Dojo 2 - cli command for building applications
http://dojo.io
Other
4 stars 19 forks source link

Include optimize-css-assets-webpack-plugin for dist build. #124

Closed tomdye closed 7 years ago

tomdye commented 7 years ago

Type: bug / feature

The following has been addressed in the PR:

Description: Adds OptimizeCssAssetsPlugin for dist mode.

Resolves #123

tomdye commented 7 years ago

This currently removes the CSS sourcemaps as well. Do we want these for our built CSS?

mwistrand commented 7 years ago

This build is failing to due to a breaking change in one of webpack's modules used by CoreLoadPlugin. There is a fix included in #122, but the build failure is unrelated to any functionality included in this PR.

codecov[bot] commented 7 years ago

Codecov Report

Merging #124 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #124   +/-   ##
=======================================
  Coverage   95.99%   95.99%           
=======================================
  Files          11       11           
  Lines         624      624           
  Branches      131      131           
=======================================
  Hits          599      599           
  Misses         13       13           
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 92c1d13...95abab1. Read the comment docs.

tomdye commented 7 years ago

@mwistrand im just going to have a quick look to see if i can turn sourcemaps on, this cssProcessorOptions: { sourcemap: true } should do it.

mwistrand commented 7 years ago

@tomdye Am I correct that cssnano does not provide an option for external source maps? So far I only see inline source map support, which, as you pointed out, adds a lot of weight to the built CSS file.