search

dojo / cli-build-webpack

🚀 **DEPRECATED** Dojo 2 - cli command for building applications
http://dojo.io
Other
4 stars 19 forks source link

Add option to reuse CLDR data from previous builds #126

Closed mwistrand closed 7 years ago

mwistrand commented 7 years ago

Type: bug

The following has been addressed in the PR:

Description:

When running in watch mode, cache any CLDR data URLs parsed from previous builds in order to prevent future, partial builds from obliterating injected CLDR data.

The one downside to caching URLs is that any removed URLs will not be removed from the build until after a hard restart. But given that CLDR data will be rarely added or removed from a project, this is unlikely to be problematic.

Resolves #125

codecov[bot] commented 7 years ago

Codecov Report

Merging #126 into master will increase coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
+ Coverage   96.01%   96.03%   +0.02%     
==========================================
  Files          11       11              
  Lines         627      631       +4     
  Branches      131      133       +2     
==========================================
+ Hits          602      606       +4     
  Misses         13       13              
  Partials       12       12
Impacted Files Coverage Δ
src/plugins/I18nPlugin.ts 95.37% <100%> (+0.17%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 453fc70...0ef082e. Read the comment docs.