Closed lzhoucs closed 7 years ago
Hi @lzhoucs thanks for the changes, this had an issue raised #130 and has an outstanding PR here #134
Oh, sorry about that @agubler. I should have looked at opened PRs before create this one. I closed this one.
Merging #136 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #136 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 11 11
Lines 627 627
Branches 131 131
=======================================
Hits 602 602
Misses 13 13
Partials 12 12
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update 2af3abe...51d1fe3. Read the comment docs.
No problem at all @lzhoucs, thank you for taking the time to raise a fix π
Following the
readme
, I ran into an error when trying to install the package with name: "@dojo/cli-build":This PR updates the npm package name to what is currently published on npm.