search

dojo / cli-build-webpack

🚀 **DEPRECATED** Dojo 2 - cli command for building applications
http://dojo.io
Other
4 stars 19 forks source link

Allow external CSS modules to be imported. #138

Closed mwistrand closed 7 years ago

mwistrand commented 7 years ago

Type: bug

The following has been addressed in the PR:

Description:

Updates the css-module-dts-loader loader to allow CSS modules outside of src/ to be loaded. With this any, any path that does not begin with a dot (.) is assumed to be either an absolute path or mid.

Also moves the util/ modules from src/plugins/util/ to src/util/ since they are no longer used only by or only useful to plugins.

Resolves #112

codecov[bot] commented 7 years ago

Codecov Report

Merging #138 into master will increase coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   96.03%   96.06%   +0.02%     
==========================================
  Files          11       11              
  Lines         631      635       +4     
  Branches      133      135       +2     
==========================================
+ Hits          606      610       +4     
  Misses         13       13              
  Partials       12       12
Impacted Files Coverage Δ
src/util/i18n.ts 98.48% <ø> (ø)
src/util/parser.ts 87.23% <ø> (ø)
src/util/main.ts 94.11% <ø> (ø)
src/plugins/InjectModulesPlugin.ts 100% <100%> (ø) :arrow_up:
src/loaders/css-module-dts-loader/loader.ts 98.27% <100%> (+0.12%) :arrow_up:
src/plugins/I18nPlugin.ts 95.37% <100%> (ø) :arrow_up:
src/plugins/CoreLoadPlugin.ts 97.87% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1a984d4...5441121. Read the comment docs.

kitsonk commented 7 years ago

Closing in favour of #178