dojo / cli-build-webpack

🚀 **DEPRECATED** Dojo 2 - cli command for building applications
http://dojo.io
Other
4 stars 19 forks source link

Reject on Webpack compilation errors #153

Closed lzhoucs closed 6 years ago

lzhoucs commented 7 years ago

Type: bug fix

The following has been addressed in the PR:

Description:

This PR adds the logic to reject on compilation errors so subsequent dojo cli commands won't run. The same logic is used in Webpack cli code.

TypeScript compilation errors are exposed by Webpack through stats.compilation.errors which can be checked with stats.hasErrors().

Resolves https://github.com/dojo/cli-test-intern/issues/31

kitsonk commented 6 years ago

@matt-gadd we should either merge or close

mwistrand commented 6 years ago

I believe this was actually fixed with #208.

kitsonk commented 6 years ago

Closing as fixed by #208