Closed lzhoucs closed 6 years ago
Type: bug fix
The following has been addressed in the PR:
Description:
This PR adds the logic to reject on compilation errors so subsequent dojo cli commands won't run. The same logic is used in Webpack cli code.
Webpack
TypeScript compilation errors are exposed by Webpack through stats.compilation.errors which can be checked with stats.hasErrors().
stats.compilation.errors
stats.hasErrors()
Resolves https://github.com/dojo/cli-test-intern/issues/31
@matt-gadd we should either merge or close
I believe this was actually fixed with #208.
Closing as fixed by #208
Type: bug fix
The following has been addressed in the PR:
Description:
This PR adds the logic to reject on compilation errors so subsequent dojo cli commands won't run. The same logic is used in
Webpack
cli code.TypeScript compilation errors are exposed by
Webpack
throughstats.compilation.errors
which can be checked withstats.hasErrors()
.Resolves https://github.com/dojo/cli-test-intern/issues/31