dojo / cli-build-webpack

🚀 **DEPRECATED** Dojo 2 - cli command for building applications
http://dojo.io
Other
4 stars 19 forks source link

Changes to get `composes` working with css-modules and our build system #167

Closed tomdye closed 7 years ago

tomdye commented 7 years ago

Type: bug / feature

The following has been addressed in the PR:

Resolves #166

tomdye commented 7 years ago

@kitsonk what do you want me to do re. the file showing as uncovered even though it's now clearly tested?

kitsonk commented 7 years ago

what do you want me to do re. the file showing as uncovered even though it's now clearly tested?

Find out why it isn't being covered? It is being instrumented, but the tests don't actually seem to be covering it. https://codecov.io/gh/dojo/cli-build/pull/167/diff

agubler commented 7 years ago

@tomdye can you resolve the conflicts please 👍

kitsonk commented 7 years ago

Also, let's not worry about the coverage for this too... so if we rebase than I would be comfortable with a merge.