dojo / cli-build-webpack

🚀 **DEPRECATED** Dojo 2 - cli command for building applications
http://dojo.io
Other
4 stars 19 forks source link

Use the package name to set the jsonpFunction #201

Closed mwistrand closed 7 years ago

mwistrand commented 7 years ago

Type: bug

The following has been addressed in the PR:

Description:

Uses the name from package.json to generate a valid JavaScript function name to be used as the output.jsonpFunction, effectively preventing different builds from accidentally loading from the wrong bundle. The config uses simple character replacement to separate words with an underscore. For example @dojo/cli-build-webpack would become dojoWebpackJsonp_cli_build_webpack.

These changes were verified locally against an application containing multiple independent bundles.

Resolves #158