dojo / cli-build-webpack

🚀 **DEPRECATED** Dojo 2 - cli command for building applications
http://dojo.io
Other
4 stars 19 forks source link

Custom elements should not be built as libraries #202

Closed mwistrand closed 7 years ago

mwistrand commented 7 years ago

Bug

If I create a custom element and build it with $ dojo build --element={elementPath}, the generated build is wrapped with a UMD wrapper. If there is an AMD define in the global namespace, however, and the environment finishes loading the custom element build after the loader, then the custom element's factory is not executed immediately but instead passed to a define call. Given the nature of custom elements, the UMD wrapper is likely unnecessary and should be removed.