search

dojo / cli-build-webpack

🚀 **DEPRECATED** Dojo 2 - cli command for building applications
http://dojo.io
Other
4 stars 19 forks source link

Bundle size reporting #28

Closed bitpshr closed 7 years ago

bitpshr commented 7 years ago

Type: feature

The following has been addressed in the PR:

Description:

sunburst

This PR adds bundle size reporting to production webpack builds by generating a report.html file in the dist folder. It makes use of bitpshr/webpack-bundle-analyzer-sunburst which was forked from th0r/webpack-bundle-analyzer and modified to support non-commercial sunbursts charts via a hand-rolled d3 implementation. I manually tested this on a generated Dojo 2 app, TodoMVC, and Monster Cards, and everything seemed fine. I verified that the size of each file on disk equaled the parsed file size in the report. It may be good for @matt-gadd or someone more familiar with webpack to double-check the output for an example project.

We may also want @itorrey to work up a better design, but I don't think this is a blocker. It's slightly annoying that we can't see size information by the cursor when hovering chart segments.

Resolves #27

codecov-io commented 7 years ago

Current coverage is 100% (diff: 100%)

Merging #28 into master will not change coverage

@@           master   #28   diff @@
===================================
  Files           1     1          
  Lines          34    34          
  Methods         0     0          
  Messages        0     0          
  Branches        4     4          
===================================
  Hits           34    34          
  Misses          0     0          
  Partials        0     0

Powered by Codecov. Last update 94b8ae8...b5b1db4