dojo / cli-build-widget

Command for building Dojo widgets
Other
6 stars 18 forks source link

Support standard NODE_ENV for production builds #21

Closed rorticus closed 6 years ago

rorticus commented 6 years ago

Adding DefinePlugin for production builds to add NODE_ENV.

codecov[bot] commented 6 years ago

Codecov Report

Merging #21 into master will increase coverage by 0.08%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   70.73%   70.82%   +0.08%     
==========================================
  Files           8        8              
  Lines         328      329       +1     
  Branches       57       57              
==========================================
+ Hits          232      233       +1     
  Misses         87       87              
  Partials        9        9
Impacted Files Coverage Δ
src/dist.config.ts 50% <ø> (+2.38%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 35cd75e...251500f. Read the comment docs.

rorticus commented 6 years ago

Merging to get this into the next release, will work on the cli-build-app equivalent on Friday