dojo / cli-build-widget

Command for building Dojo widgets
Other
6 stars 17 forks source link

Evergreen builds do not transform CSS variables #37

Closed rorticus closed 5 years ago

rorticus commented 6 years ago

Update to disable css custom properties when not doing a legacy build.

Before:

--my-color: blue;

.myClass {
    color: blue;
    color: var(--my-color);
}

Now,

--my-color: blue;

.myClass {
    color: var(--my-color);
}
codecov[bot] commented 6 years ago

Codecov Report

Merging #37 into master will decrease coverage by 0.19%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #37     +/-   ##
=========================================
- Coverage   70.83%   70.63%   -0.2%     
=========================================
  Files           8        8             
  Lines         360      361      +1     
  Branches       63       64      +1     
=========================================
  Hits          255      255             
- Misses        105      106      +1
Impacted Files Coverage Δ
src/base.config.ts 33.87% <0%> (-0.56%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e7d398a...6953bef. Read the comment docs.

agubler commented 5 years ago

Closing for now (very outdated), we might address this in a subsequent change