dojo / cli-build-widget

Command for building Dojo widgets

Other

6 stars 17 forks source link

Adding support for custom element transformer #53

Closed rorticus closed 5 years ago

rorticus commented 5 years ago

Adding support for the new custom element transformer.

Notable changes:

Upgrading to @dojo/framework 6.0.0-alpha to get changes to registerCustomElement
Upgrading ts-loader because we need at least 5.3.3 (includes support for sending program instance to custom transformers)
Turning off onlyCompileBundledFiles so that all type information is sent to custom transformers.
Removed test files from test-app/ that weren't being used
Removed @customElement decorators from test-app/ widgets, relying on new custom element transformer instead.

Relates to: https://github.com/dojo/webpack-contrib/issues/43

rorticus commented 5 years ago

Note that CI isn't going to pass as it's dependent on https://github.com/dojo/webpack-contrib/pull/133

codecov[bot] commented 5 years ago

Codecov Report

Merging #53 into master will decrease coverage by 0.71%. The diff coverage is 20%.

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage    71.3%   70.58%   -0.72%     
==========================================
  Files           8        8              
  Lines         352      357       +5     
  Branches       59       60       +1     
==========================================
+ Hits          251      252       +1     
- Misses        101      105       +4

Impacted Files	Coverage Δ
src/base.config.ts	`33.82% <20%> (-1.1%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b1cea44...512334e. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #53 into master will decrease coverage by 0.63%. The diff coverage is 55.55%.

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage    71.3%   70.67%   -0.64%     
==========================================
  Files           8        8              
  Lines         352      358       +6     
  Branches       59       59              
==========================================
+ Hits          251      253       +2     
- Misses        101      105       +4

Impacted Files	Coverage Δ
src/main.ts	`95.27% <100%> (+0.03%)`	:arrow_up:
src/base.config.ts	`33.82% <20%> (-1.1%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b1cea44...ff2ab89. Read the comment docs.