dojo / cli-build-widget

Command for building Dojo widgets

Other

6 stars 17 forks source link

Updates for custom element transformer #58

Closed maier49 closed 5 years ago

maier49 commented 5 years ago

Updates framework dependencies to 6.0.0-alpha.12 for latest function-based widget API
Converts Menu to a function-based widget to test transformer updates
Removes custom element transformer from lib build. Evidently these custom elements would not be usable anyways, and the onlyCompileBundledFiles flag used for that build means that the TS checker in the transformer can't see the types from @dojo/framework which is necessary for the function-based custom element transformation.

This shouldn't be merged until webpack-contrib and framework are both released with the needed changes.

codecov[bot] commented 5 years ago

Codecov Report

Merging #58 into master will decrease coverage by 0.32%. The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage    64.5%   64.17%   -0.33%     
==========================================
  Files           8        8              
  Lines         400      402       +2     
  Branches       83       85       +2     
==========================================
  Hits          258      258              
- Misses        142      144       +2

Impacted Files	Coverage Δ
src/base.config.ts	`23.52% <0%> (-0.48%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2a41f11...65a81ce. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #58 into master will decrease coverage by 0.32%. The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage    64.5%   64.17%   -0.33%     
==========================================
  Files           8        8              
  Lines         400      402       +2     
  Branches       83       85       +2     
==========================================
  Hits          258      258              
- Misses        142      144       +2

Impacted Files	Coverage Δ
src/base.config.ts	`23.52% <0%> (-0.48%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2a41f11...65a81ce. Read the comment docs.