search

dojo / cli-build-widget

Command for building Dojo widgets
Other
6 stars 17 forks source link

Upgrade lint staged to prevent observeable error #67

Closed JamesLMilner closed 4 years ago

JamesLMilner commented 4 years ago

Type: bug

Description:

When trying to commit, the pre commit hook was failing with the follow error:

husky > npm run -s precommit (node v10.16.1)

/home/james/Code/SitePen/dojo/cli/node_modules/any-observable/register.js:29
                throw new Error('Cannot find any-observable implementation nor' +
                ^

Error: Cannot find any-observable implementation nor global.Observable. You must install polyfill or call require("any-observable/register") with your preferred implementation, e.g. require("any-observable/register")('rxjs') on application load prior to any require("any-observable").
    at loadImplementation (/home/james/Code/SitePen/dojo/cli/node_modules/any-observable/register.js:29:9)
    at register (/home/james/Code/SitePen/dojo/cli/node_modules/any-observable/loader.js:32:18)
    at Object.<anonymous> (/home/james/Code/SitePen/dojo/cli/node_modules/any-observable/index.js:2:39)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)

This PR brings lint-staged up to date and fixes the issue (as per https://github.com/okonet/lint-staged/issues/416#issuecomment-458830064)

codecov[bot] commented 4 years ago

Codecov Report

Merging #67 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #67   +/-   ##
=======================================
  Coverage   63.95%   63.95%           
=======================================
  Files           8        8           
  Lines         405      405           
  Branches       88       88           
=======================================
  Hits          259      259           
  Misses        146      146

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a6a4b8d...3b1806f. Read the comment docs.