search

dojo / cli-build-widget

Command for building Dojo widgets
Other
6 stars 17 forks source link

Switching to webpack-contribs istanbul-loader #80

Closed rorticus closed 4 years ago

rorticus commented 4 years ago

The regular istanbul-instrumenter-loader was being fussy and including the loader paths in the coverage report, resulting in mass hysteria. Using the one from webpack-contrib solves the issue!

To test, I compared the results from a fresh copy of @dojo/widgets to a copy generated using this new loader. The results are identical! 🎉

codecov[bot] commented 4 years ago

Codecov Report

Merging #80 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   61.67%   61.67%           
=======================================
  Files           9        9           
  Lines         454      454           
  Branches       98       98           
=======================================
  Hits          280      280           
  Misses        174      174
Impacted Files Coverage Δ
src/functional.config.ts 16.21% <ø> (ø) :arrow_up:
src/unit.config.ts 16.21% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3e5a219...8926312. Read the comment docs.