dojo / cli-build-widget

Command for building Dojo widgets
Other
6 stars 17 forks source link

Extracting shared resources out to a bootstrap file #95

Open rorticus opened 4 years ago

rorticus commented 4 years ago

Currently, each custom element bundle contains a copy of the vdom. This is inefficient and bloats the bundle size.

This PR extracts anything used more than twice from node_modules into a common bootstrap chunk. This bootstrap chunk will contain the dojo framework and other modules shared between your elements and will only need to be loaded once.

What this means is:

Note: This is a breaking change, as it modifies the generated chunks

codecov[bot] commented 4 years ago

Codecov Report

Merging #95 (578e0f4) into master (3c588a2) will decrease coverage by 0.11%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage   57.00%   56.88%   -0.12%     
==========================================
  Files           9        9              
  Lines         500      501       +1     
  Branches      122      122              
==========================================
  Hits          285      285              
- Misses        215      216       +1     
Impacted Files Coverage Δ
src/base.config.ts 19.01% <0.00%> (-0.14%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3c588a2...578e0f4. Read the comment docs.