Closed tomdye closed 7 years ago
Merging #108 into master will decrease coverage by
-0.06%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #108 +/- ##
==========================================
- Coverage 99.49% 99.43% -0.06%
==========================================
Files 15 15
Lines 394 357 -37
Branches 49 38 -11
==========================================
- Hits 392 355 -37
Partials 2 2
Impacted Files | Coverage Δ | |
---|---|---|
src/npmInstall.ts | 100% <100%> (ø) |
:white_check_mark: |
src/allCommands.ts | 100% <100%> (ø) |
:white_check_mark: |
src/commands/eject.ts | 100% <100%> (ø) |
:white_check_mark: |
src/command.ts | 100% <100%> (ø) |
:white_check_mark: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 477e35b...b0adecf. Read the comment docs.
I think we should add all the ejected config inside a root folder such as config
similar to create-react-app
, otherwise it will clutter the root directory.
@agubler all checks / coverage passed now
Updates to
eject
command internals.scripts
support, we don't use them.eject
rather than providing npm and copy files functions to the eject command.path
to copy response to make relative file naming easiereject
to command wrapperWARN
for commands that don't supporteject
group/name
output togroup-name
to match command filenamesFixes: #105 #104 #106 #107 Blocks: https://github.com/dojo/cli-build/issues/58