dojo / cli

:rocket: Dojo - command line tooling.
http://dojo.io
Other
26 stars 34 forks source link

Change config helper to use sync and have config per command #110

Closed tomdye closed 7 years ago

tomdye commented 7 years ago

Blocks: https://github.com/dojo/cli-build/issues/58 Fixes: https://github.com/dojo/cli/issues/112 #104 #106

codecov-io commented 7 years ago

Codecov Report

Merging #110 into master will increase coverage by 0.01%. The diff coverage is 97.5%.

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
+ Coverage   99.43%   99.45%   +0.01%     
==========================================
  Files          15       15              
  Lines         357      364       +7     
  Branches       38       40       +2     
==========================================
+ Hits          355      362       +7     
  Partials        2        2
Impacted Files Coverage Δ
src/commands/eject.ts 100% <100%> (ø) :white_check_mark:
src/CommandHelper.ts 100% <100%> (ø) :white_check_mark:
src/configurationHelper.ts 100% <100%> (ø)
src/registerCommands.ts 100% <100%> (ø) :white_check_mark:
src/loadCommands.ts 97.29% <92.3%> (+0.42%) :white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 32c02a8...d1bfe42. Read the comment docs.

tomdye commented 7 years ago

@agubler this is ready for review now. Fully working and tested.