search

dojo / cli

:rocket: Dojo - command line tooling.
http://dojo.io
Other
25 stars 34 forks source link

Use `@types/yargs` #120

Closed agubler closed 7 years ago

agubler commented 7 years ago

Type: feature

The following has been addressed in the PR:

Description:

Convert to use @types/yargs.

Discussion as we do lose the typings for Argv that seem to be typed as any in the latest yarg types from @types.

Resolves #119

codecov-io commented 7 years ago

Codecov Report

Merging #120 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #120   +/-   ##
=======================================
  Coverage   99.45%   99.45%           
=======================================
  Files          15       15           
  Lines         369      369           
  Branches       42       42           
=======================================
  Hits          367      367           
  Partials        2        2
Impacted Files Coverage Δ
src/Helper.ts 100% <ø> (ø) :arrow_up:
src/CommandHelper.ts 100% <ø> (ø) :arrow_up:
src/commands/eject.ts 100% <ø> (ø) :arrow_up:
src/registerCommands.ts 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 153c571...7f5cb81. Read the comment docs.

dylans commented 7 years ago

@agubler any reason to not land this after a rebase?

agubler commented 7 years ago

@dylans just the fact that the typings don't seem to be quite as good. Also it's a breaking change as we'd need to convert all the commands.