dojo / cli

:rocket: Dojo - command line tooling.
http://dojo.io
Other
26 stars 34 forks source link

Parse dashed command names properly #143

Closed kitsonk closed 7 years ago

kitsonk commented 7 years ago

Type: bug

The following has been addressed in the PR:

Description:

This PR fixes issues when a command has a dash in it's name. Commands like cli-foo-bar-baz will be parsed as a group of foo and a name of bar-baz. Previously, these were being parsed as foo-bar and baz.

This will mean that group names cannot be dashed.

Resolves #142

codecov[bot] commented 7 years ago

Codecov Report

Merging #143 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #143   +/-   ##
=======================================
  Coverage   98.92%   98.92%           
=======================================
  Files          15       15           
  Lines         373      373           
  Branches       44       44           
=======================================
  Hits          369      369           
  Partials        4        4
Impacted Files Coverage Δ
src/command.ts 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c797396...7c57f63. Read the comment docs.

codecov[bot] commented 7 years ago

Codecov Report

Merging #143 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #143   +/-   ##
=======================================
  Coverage   98.92%   98.92%           
=======================================
  Files          15       15           
  Lines         373      373           
  Branches       44       44           
=======================================
  Hits          369      369           
  Partials        4        4
Impacted Files Coverage Δ
src/command.ts 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c797396...d6c6f81. Read the comment docs.