search

dojo / cli

:rocket: Dojo - command line tooling.
http://dojo.io
Other
26 stars 34 forks source link

Fix unhandled promise rejections #166

Closed JamesLMilner closed 6 years ago

JamesLMilner commented 6 years ago

Type: Bug

The following has been addressed in the PR:

Description:

Resolves #150. It appears the issue was that stub.resolves is used but a promise was being returned back too, creating a double stacked promise. Simply returning a string resolved it. I've also handled potentially failing promises in the tests themselves, and set process to give a stack trace for any unhandled promises in future.

On another note you still get two 'test error message' from the tests even though it implies they all passed. Any ideas on that? It's the same on master too.

codecov[bot] commented 6 years ago

Codecov Report

Merging #166 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #166   +/-   ##
=====================================
  Coverage      99%    99%           
=====================================
  Files          16     16           
  Lines         404    404           
  Branches       50     50           
=====================================
  Hits          400    400           
  Partials        4      4

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8d9e7a4...fdf92d9. Read the comment docs.

codecov-io commented 6 years ago

Codecov Report

Merging #166 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #166   +/-   ##
=====================================
  Coverage      99%    99%           
=====================================
  Files          16     16           
  Lines         404    404           
  Branches       50     50           
=====================================
  Hits          400    400           
  Partials        4      4

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8d9e7a4...aff531e. Read the comment docs.