search

dojo / cli

:rocket: Dojo - command line tooling.
http://dojo.io
Other
26 stars 34 forks source link

eject Command should not load its configuration directly #173

Closed kitsonk closed 6 years ago

kitsonk commented 6 years ago

Enhancement

eject directly requires the .dojorc. It should use the helper like other commands.

Refs: #172

agubler commented 6 years ago

Is this possible as the helper will only give the section of .dojorc for the command that is using the helper, but the eject command needs to add entries to the other commands' sections?

kitsonk commented 6 years ago

Possibly, but there should still be an abstraction for it, especially if we move to allowing it to be added to the package.json right?

agubler commented 6 years ago

We should certainly be more graceful in handling errors loading the .dojorc, I imagine the change to allow using the package.json would be an issue of its own.

agubler commented 6 years ago

And we have an issue open specifically for that change https://github.com/dojo/cli/issues/160

kitsonk commented 6 years ago

Closing in favour of #160