Closed umaar closed 6 years ago
Merging #180 into master will decrease coverage by
0.87%
. The diff coverage is81.81%
.
@@ Coverage Diff @@
## master #180 +/- ##
==========================================
- Coverage 97.9% 97.02% -0.88%
==========================================
Files 16 17 +1
Lines 382 404 +22
Branches 49 51 +2
==========================================
+ Hits 374 392 +18
- Misses 3 5 +2
- Partials 5 7 +2
Impacted Files | Coverage Δ | |
---|---|---|
src/CommandHelper.ts | 100% <100%> (ø) |
:arrow_up: |
src/template.ts | 78.94% <78.94%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e015613...de4dc8f. Read the comment docs.
Thanks @rorticus ! Could you also check the interfaces pull request too: https://github.com/dojo/interfaces/pull/86 (just so I can merge them at the same time)
Thanks @tomdye do you mind approving https://github.com/dojo/interfaces/pull/86 too because I think we need to merge that and this at the same time
I have made issues for both those repos and linked to them in the description of this PR
Type: feature
The following has been addressed in the PR:
Description:
This PR migrates the renderFiles implementation from another repo, into this repository which means other external CLI commands can benefit from it.
Once it has been merged, we can remove https://github.com/dojo/cli-create-app/blob/master/src/renderFiles.ts and make that repo use this implementation., issue to do this: https://github.com/dojo/cli-create-app/issues/127 also https://github.com/dojo/cli-create-widget/issues/6
Should also merge: https://github.com/dojo/interfaces/pull/86