Closed tomdye closed 6 years ago
Merging #200 into master will decrease coverage by
2.23%
. The diff coverage is86.45%
.
@@ Coverage Diff @@
## master #200 +/- ##
=========================================
- Coverage 97.03% 94.8% -2.24%
=========================================
Files 17 19 +2
Lines 405 481 +76
Branches 53 65 +12
=========================================
+ Hits 393 456 +63
- Misses 5 14 +9
- Partials 7 11 +4
Impacted Files | Coverage Δ | |
---|---|---|
src/command.ts | 97.29% <ø> (ø) |
:arrow_up: |
src/config.ts | 100% <ø> (ø) |
:arrow_up: |
src/allCommands.ts | 100% <ø> (ø) |
:arrow_up: |
src/CommandHelper.ts | 100% <ø> (ø) |
:arrow_up: |
src/detachedCheckForNewCommands.ts | 0% <0%> (ø) |
|
src/commands/eject.ts | 94.23% <100%> (+0.11%) |
:arrow_up: |
src/commands/version.ts | 98.41% <100%> (ø) |
:arrow_up: |
src/configurationHelper.ts | 100% <100%> (ø) |
:arrow_up: |
src/template.ts | 78.94% <100%> (ø) |
:arrow_up: |
src/registerCommands.ts | 100% <100%> (ø) |
:arrow_up: |
... and 7 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7ac59e7...54aebbc. Read the comment docs.
re. the color changes, it is something that we have thought about, worth raising an issue for as there is a solution out there for colouring in the description. Looks like the command name colour itself is a bit of a hack so unlikely to go down that route.
re. the general output, again this should be addressed in an issue, the purpose of this PR is simply to show the available commands in the same format as we currently show installed ones.
@umaar most comments addressed
Type: bug / feature
The following has been addressed in the PR:
Description:
Adds command discovery ability to the CLI. All commands including those that have not been installed will now show when you run
dojo
.src/interfaces
Screenshots below show
index.js
as I'm running command from build source vianode index.js
.Resolves #184 Supersedes: https://github.com/dojo/cli/pull/190