search

dojo / cli

:rocket: Dojo - command line tooling.
http://dojo.io
Other
26 stars 34 forks source link

A broken test builde returns with exit code zero #209

Closed szwoelf closed 6 years ago

szwoelf commented 6 years ago

Enhancement

When building tests with dojo build -m test the return code to the operating system is zero even if the build process fails.

Package Version: 0.5.0

Expected behavior:

A non zero return code will possibly be more appropriate and ensure that the build breaks a CI build chain.

szwoelf commented 6 years ago

This is also true if linting fails. Here also the build continues ... possibly this is desired but on automatic builds it is unexpected.

agubler commented 6 years ago

This works for all commands provided they don't swallow errors, unfortunately cli-build-app does not return an error back to the CLI when there has been a build failure - will need to add changes to cli-build-app to ensure this returns back as expected on a failure.

szwoelf commented 6 years ago

Thank you for the fix.