dojo / cli

:rocket: Dojo - command line tooling.
http://dojo.io
Other
26 stars 34 forks source link

Enable all command line options to be provided by the .dojorc config file #217

Closed agubler closed 6 years ago

agubler commented 6 years ago

Type: feature

The following has been addressed in the PR:

Description:

Enable all command line options to be specified via the .dojorc but still overridable by the command line when explicitly specified.

Order of precedence:

1) Explicitly specified command line options 2) .dojorc configuration 3) Default value for command line options

Resolves #210

codecov[bot] commented 6 years ago

Codecov Report

Merging #217 into master will increase coverage by 0.32%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
+ Coverage   94.74%   95.06%   +0.32%     
==========================================
  Files          19       19              
  Lines         476      507      +31     
  Branches       62       69       +7     
==========================================
+ Hits          451      482      +31     
  Misses         13       13              
  Partials       12       12
Impacted Files Coverage Δ
src/registerCommands.ts 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0ebf262...8630984. Read the comment docs.

agubler commented 6 years ago

@tomdye yup good point I'll add a section in the readme

agubler commented 6 years ago

@tomdye added a section in the readme on the dojorc.