Closed agubler closed 6 years ago
Am completely open to suggestions to the formatting and colours and also if I've missed anything.
Merging #229 into master will decrease coverage by
0.91%
. The diff coverage is95.83%
.
@@ Coverage Diff @@
## master #229 +/- ##
==========================================
- Coverage 95.04% 94.13% -0.92%
==========================================
Files 19 20 +1
Lines 525 597 +72
Branches 70 95 +25
==========================================
+ Hits 499 562 +63
- Misses 13 17 +4
- Partials 13 18 +5
Impacted Files | Coverage Δ | |
---|---|---|
src/commands/version.ts | 98.41% <100%> (+0.05%) |
:arrow_up: |
src/commands/init.ts | 100% <100%> (ø) |
:arrow_up: |
src/installableCommands.ts | 89.36% <100%> (-0.97%) |
:arrow_down: |
src/allCommands.ts | 100% <100%> (ø) |
:arrow_up: |
src/loadCommands.ts | 100% <100%> (+5.12%) |
:arrow_up: |
src/validation.ts | 100% <100%> (ø) |
|
src/index.ts | 100% <100%> (ø) |
:arrow_up: |
src/commands/eject.ts | 94.33% <100%> (+0.22%) |
:arrow_up: |
src/CommandHelper.ts | 90.47% <81.81%> (-9.53%) |
:arrow_down: |
src/command.ts | 94.44% <85.71%> (-2.86%) |
:arrow_down: |
... and 6 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 538eff7...91035f7. Read the comment docs.
Needs more test coverage!
@tomdye I think for now the padding works but I defo want to look at using cli-table for the layout.
Updated CLI output with some extra colour and different ascii art for dojo
@tomdye @rorticus Have changed the output slightly if you could take another look.
wow that's fancy :)
Art courtesy of @matt-gadd 😄
Type: feature
The following has been addressed in the PR:
prettier
as per the readme code style guidelinesDescription:
Handles help output explicitly for the CLI and commands with a custom help renderer. Also needed some significant changes in the way that commands are registered:
CommandMap
andYargsCommandNames
to a singleGroupMap
so that they are not managed over two objectsglobal
, defaults tofalse
CommandWrapper
-global
,installed
,default
default
is set on the first registered command for a group (same as before)installed
is set to false for commands found fromnpm
aliases
as no commands currently use it and it complicates the help renderer.Temporarily hard coded
create-app
to be a global command as it's the "dojo" global external command.Main CLI help output
Group CLI help output
Command CLI help output
Installable command CLI help output
Resolves #227
Resolves #228