Closed rorticus closed 6 years ago
Merging #236 into master will decrease coverage by
0.1%
. The diff coverage is93.1%
.
@@ Coverage Diff @@
## master #236 +/- ##
==========================================
- Coverage 94.12% 94.02% -0.11%
==========================================
Files 20 20
Lines 596 619 +23
Branches 95 101 +6
==========================================
+ Hits 561 582 +21
- Misses 17 18 +1
- Partials 18 19 +1
Impacted Files | Coverage Δ | |
---|---|---|
src/configurationHelper.ts | 93.87% <93.1%> (-2.28%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ae3bf3a...a3ffd8d. Read the comment docs.
Merging #236 into master will increase coverage by
0.19%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #236 +/- ##
==========================================
+ Coverage 94.16% 94.36% +0.19%
==========================================
Files 20 20
Lines 600 621 +21
Branches 95 100 +5
==========================================
+ Hits 565 586 +21
Misses 17 17
Partials 18 18
Impacted Files | Coverage Δ | |
---|---|---|
src/configurationHelper.ts | 98.03% <100%> (+1.37%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 14f3c88...916aa36. Read the comment docs.
Closing in favor of https://github.com/dojo/cli/pull/260
Type: feature
The following has been addressed in the PR:
prettier
as per the readme code style guidelinesDescription:
Adding the ability to read from
.dojorc
configuration frompackage.json
. If thedojo
key exists in yourpackage.json
...And
.dojorc
does not exist, the config will be read frompackage.json
. When you try to write config, and it's stored inpackage.json
, you get a confirmation.Additionally, you can now pass a command name into the
get()
method in order to read configuration that belongs to another command. Note that this applies to read only. You still cannot write to another command's config.All of this is to support future work on
@dojo/cli-create-theme
to read a list of themeable elements that will be stored inpackage.json
.