dojo / cli

:rocket: Dojo - command line tooling.
http://dojo.io
Other
25 stars 34 forks source link

Merge command groups instead of overriding #268

Closed KaneFreeman closed 6 years ago

KaneFreeman commented 6 years ago

Type: bug

The following has been addressed in the PR:

Description: When the same command group is built in and installed, the commands should be merged instead of the built in command group overriding the installed.

Resolves #197

codecov[bot] commented 6 years ago

Codecov Report

Merging #268 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
+ Coverage   98.04%   98.06%   +0.01%     
==========================================
  Files          21       21              
  Lines         819      826       +7     
  Branches      133      134       +1     
==========================================
+ Hits          803      810       +7     
  Misses         16       16
Impacted Files Coverage Δ
src/allCommands.ts 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3e68952...a634e7f. Read the comment docs.

agubler commented 6 years ago

Can we get a unit test for this?

KaneFreeman commented 6 years ago

@agubler I have moved the combining code into a separate function and built a unit test for that function.