Add ajv validation - Githubissues

dojo / cli

:rocket: Dojo - command line tooling.

http://dojo.io

Other

26 stars 34 forks source link

Add ajv validation #274

Closed JamesLMilner closed 5 years ago

JamesLMilner commented 5 years ago

Type: feature

The following has been addressed in the PR:

[ ] There is a related issue
[ ] All code has been formatted with prettier as per the readme code style guidelines
[ ] Unit or Functional tests are included in the PR

Description:

Uses ajv instead of jsonschema

screenshot_20190128_224651

agubler commented 5 years ago

@JamesMilnerUK What is the status of this?

JamesLMilner commented 5 years ago

@agubler I think it's 90% there. I think as I left a comment above it tries to validate when no config is found which is probably undesirable. There's a pretty comprehensive test suite there, but might benefit from some more smoke testing with some real project configs.

agubler commented 5 years ago

@JamesMilnerUK yup a smoke test for commands with validations would help (with a .dojorc and also a package.json dojo config), also agree that it should not validate when no configuration is found.