dojo / cli

:rocket: Dojo - command line tooling.
http://dojo.io
Other
26 stars 34 forks source link

When using "base" in dojo.rc, references to webfonts in /assets are not adjusted #314

Open arndbeissner opened 3 years ago

arndbeissner commented 3 years ago

Bug

When you use the base property in .dojorc to change the base path to, for example, "/admin/" instead of "/", the generated index.html will be changed properly to reflect that. However, webfont references to locally hosted web fonts (in assets directory) are not changed - they stay at "/assets/". At runtime, the browser will reference /assets/xxx.woff instead of /admin/assets/xx.woff and will not find the webfont. Interestingly, when hosted by the dojo --serve --watch mechanism, this works. When using a production build and moving the content of the list directory to an http server, it doesn't - 404 not finding the resource. All css and js resources are resolved properly.

To be honest I am not entirely why this doesnt work. Creating this issue as discussed in Discord.

Package Version: 7.0.0

Code hello-world-webfont.zip

Sample based on the default hello world app, with only minimum modifications:

Expected behavior:

Webfont should be loaded.

Actual behavior:

Webfont is not loaded because the browser tries to load the font from /assets instead of /admin/assets