Closed rishson closed 7 years ago
Initial comments raised, still needs a more thorough review.
@@ master #75 diff @@
==========================================
Files 10 10
Lines 161 223 +62
Methods 0 0
Messages 0 0
Branches 14 19 +5
==========================================
+ Hits 160 221 +61
+ Misses 1 0 -1
- Partials 0 2 +2
Powered by Codecov. Last update 34a5840...bc75872
Don't get the codecov. grunt test
gives coverage of 99.57%, but codecov on ci
says 97.87%. Even the summary directly above this comment shows that the PR raises line and branch coverage.
Nice @rishson, merge away at your own convenience 👍
Fixes #67, #68, addresses some of #73. Adding this behaviour has meant moving the existing
version
functionality to aCommand
because the--outdated
check is async. This has caused a limited refactor. Where possible, I have not altered the code layout or functionality to keep this PR small, however, I have done the following:tslint
errors.Getting code coverage from 99.87% to 100% will require introducing extra dependencies or re-writing how the
cli
main entry func works, so I have not done this.The functionality is limited to using
npm
as thecli
module repository. Thecommand
interface now hasgroup
andname
as optional properties, because these are specified by theversion
in-built command, rather than being derived from the command's enclosing directory name.