search

dojo / core

:rocket: Dojo 2 - language helpers and utilities.
http://dojo.io
Other
213 stars 58 forks source link

POST body with request/node #198

Closed sebilasse closed 7 years ago

sebilasse commented 8 years ago

see https://github.com/dojo/core/issues/197

jquerybot commented 8 years ago

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

:memo: Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.

If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

codecov-io commented 8 years ago

Current coverage is 97.31% (diff: 100%)

Merging #198 into master will increase coverage by 6.76%

@@             master       #198   diff @@
==========================================
  Files            43         43          
  Lines          2233       2233          
  Methods          26         26          
  Messages          0          0          
  Branches        420        420          
==========================================
+ Hits           2022       2173   +151   
+ Misses          207         57   -150   
+ Partials          4          3     -1

Powered by Codecov. Last update 09d9ac1...bbc3069

kitsonk commented 8 years ago

@sebilasse thanks for the contribution. The PR looks fine, but it would be great to get tests for it before we were to merge it.

sebilasse commented 8 years ago

What would a test look like without a server?

What I also stumbled upon is the note in request/node: "TODO: This redirect code is not 100% correct according to the RFC; needs to handle redirect loops and restrict/modify certain redirects" This feels pretty important and could also be a (trackable) issue (especially because redirect loops will occur, try german lead media site "spiegel.de" [without 'www.']).

kitsonk commented 8 years ago

There is a server integrated into the test harness. The server code is located in tests/services/echo.ts and is bootstrapped when the tests are run.

rorticus commented 7 years ago

Closing because issue was closed.