improve request/util destructuring

dojo / core

:rocket: Dojo 2 - language helpers and utilities.

http://dojo.io

Other

213 stars 58 forks source link

improve request/util destructuring #203

Closed dylans closed 8 years ago

dylans commented 8 years ago

Suggestion from Kit in reviewing conference talk materials, as a way to improve our usage of destructuring.

kitsonk commented 8 years ago

Ping...

codecov-io commented 8 years ago

Current coverage is 97.42% (diff: 85.71%)

Merging #203 into master will decrease coverage by 0.04%

@@             master       #203   diff @@
==========================================
  Files            44         44          
  Lines          2325       2326     +1   
  Methods          26         26          
  Messages          0          0          
  Branches        443        444     +1   
==========================================
  Hits           2266       2266          
  Misses           56         56          
- Partials          3          4     +1

Powered by Codecov. Last update 40326b7...572260d

dylans commented 8 years ago

@kitsonk should compile properly. Lessons learned:

Don't copy an example from a conference slide where tabs are converted to spaces
Avoid grunt/npm hell
JSDoc doesn't have a proper way to document this syntax (that we know of)

dylans commented 8 years ago

Thanks @kitsonk . It is passing CI, though failing on code coverage (which is unchanged from prior to this PR).

kitsonk commented 8 years ago

Actually it is an issue with the way Istanbul is detecting/instrumenting the destructuring in the compiled code. It is seeing some branches there and they don't get covered in the down emit.