search

dojo / core

:rocket: Dojo 2 - language helpers and utilities.
http://dojo.io
Other
213 stars 58 forks source link

Add the ability to delay executing a function. (#215) #216

Closed lzhoucs closed 8 years ago

lzhoucs commented 8 years ago

This address #215. Any feedback or comments are welcome.

jquerybot commented 8 years ago

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

:memo: Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.

If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

kitsonk commented 8 years ago

We should re-base this and then in theory this should clear the CI error.

codecov-io commented 8 years ago

Current coverage is 97.42% (diff: 100%)

Merging #216 into master will not change coverage

@@             master       #216   diff @@
==========================================
  Files            44         44          
  Lines          2326       2326          
  Methods          26         26          
  Messages          0          0          
  Branches        444        445     +1   
==========================================
  Hits           2266       2266          
  Misses           56         56          
  Partials          4          4

Powered by Codecov. Last update 6a69e76...df4fd94

lzhoucs commented 8 years ago

I couldn't reproduce the following test failure in build #317 on Windows 7 IE 11. "internet explorer 11.0 on Windows 7 - unit tests - async/timing - DelayedRejection - is eventually rejected with error"

kitsonk commented 8 years ago

@lzhoucs it seems to have been a transitory issue with SauceLabs. Rerunning the CI came back clean.