search

dojo / core

:rocket: Dojo 2 - language helpers and utilities.
http://dojo.io
Other
213 stars 62 forks source link

Feature interfaces #222

Closed kitsonk closed 7 years ago

kitsonk commented 7 years ago

This PR integrates dojo-interfaces into core, meaning that common interfaces have been removed from this package and the code now references them from the dojo-interfaces packages. It also means that those wanting to consume dojo-core in TypeScript will also have to have dojo-interfaces installed, but it has not been provided as a dependency or a peer dependency, as to help ensure there are minimal downstream design time type conflicts, though if the types are not resolvable at compile time, TypeScript will error.

This builds on #221 which we should land first and rebase before merging this.

codecov-io commented 7 years ago

Current coverage is 97.46% (diff: 100%)

Merging #222 into master will increase coverage by 6.58%

@@             master       #222   diff @@
==========================================
  Files            44         44          
  Lines          2325       2325          
  Methods          26         26          
  Messages          0          0          
  Branches        443        443          
==========================================
+ Hits           2113       2266   +153   
+ Misses          208         56   -152   
+ Partials          4          3     -1

Powered by Codecov. Last update 811f8a6...57a99a6