search

dojo / core

:rocket: Dojo 2 - language helpers and utilities.
http://dojo.io
Other
213 stars 58 forks source link

Issues with load and loading dojo-shim/Promise #228

Closed kitsonk closed 7 years ago

kitsonk commented 8 years ago

When dojo-shim/Promise has not been loaded before, it cannot be required in the format of require('dojo-shim/Promise').

This does not fail in the tests because they end up loading loading dojo-shim/Promise in other ways, so it is available in the loader cache when require('dojo-shim/Promise') is called, therefore it is returned.

rishson commented 7 years ago

@kitsonk work still needed or OK to close?

kitsonk commented 7 years ago

It is likely still an issue. Someone should look into it. It was related to #224 and load and could easily be masked by the way we test.

kitsonk commented 7 years ago

Between changes to shim and the support of ES Import in TypeScript, this issue isn't worth addressing and we need to deprecate load().