Resolving unhandled promise rejection errors, #229

dojo / core

:rocket: Dojo 2 - language helpers and utilities.

http://dojo.io

Other

213 stars 58 forks source link

Resolving unhandled promise rejection errors, #229 #235

Closed rorticus closed 7 years ago

rorticus commented 8 years ago

The tests, they did throw uncaught promises a lot. Dispatching their promises, the results were forgot. Merge this PR, and then you will see, The test logs don't error, they're clean as can be.

Also, we'll probably want someone familiar with the streams to give this a quick glance to confirm that I'm not hiding any important errors. There shouldn't be anything caught now that wasn't before, but, you never know!

jsf-clabot commented 8 years ago

All committers have signed the CLA.

codecov-io commented 8 years ago

Current coverage is 97.74% (diff: 100%)

Merging #235 into master will increase coverage by 0.25%

@@             master       #235   diff @@
==========================================
  Files            46         46          
  Lines          2390       2399     +9   
  Methods          27         27          
  Messages          0          0          
  Branches        456        459     +3   
==========================================
+ Hits           2330       2345    +15   
+ Misses           58         52     -6   
  Partials          2          2

Powered by Codecov. Last update 22ac072...0033b7c