Case insensitivity when checking for user-agent header, fixes #168

dojo / core

:rocket: Dojo 2 - language helpers and utilities.

http://dojo.io

Other

213 stars 62 forks source link

Case insensitivity when checking for user-agent header, fixes #168 #236

Closed rorticus closed 7 years ago

rorticus commented 7 years ago

user-agent checking was once case sensitive, sending it mixed case caused behavior preventative. now they are normalized, so send them all capitalized, and no longer will USER-AGENT be decorative.

Note that I although I changed some case sensitivity header checking in request/xhr, I did not do anything with setting the user agent.

See,

https://dvcs.w3.org/hg/xhr/raw-file/tip/Overview.html#dom-xmlhttprequest-setrequestheader

codecov-io commented 7 years ago

Current coverage is 97.48% (diff: 100%)

Merging #236 into master will increase coverage by <.01%

@@             master       #236   diff @@
==========================================
  Files            46         46          
  Lines          2385       2388     +3   
  Methods          26         27     +1   
  Messages          0          0          
  Branches        455        455          
==========================================
+ Hits           2325       2328     +3   
  Misses           58         58          
  Partials          2          2

Powered by Codecov. Last update ce12d31...2116612