search

dojo / core

:rocket: Dojo 2 - language helpers and utilities.
http://dojo.io
Other
213 stars 58 forks source link

TypeScript 2.1: Use of super and this #238

Closed kitsonk closed 7 years ago

kitsonk commented 7 years ago

Because of the new transformation based emitter, ES6 code that used to incorrectly compile to ES5 and "work" is now broken in an ES6 emit and the ES5 emit. Basically, it has to do with the availability of this when passing a function to super() in a class. This effects the "unwrapping" of promises when subclassing (like our ExtensiblePromise and Task). The issue Microsoft/TypeScript#8060 describes it.

taoqf commented 7 years ago

module + function + Data with no classes will do very perfectly.

dylans commented 7 years ago

Already resolved and in use where relevant.