lzhoucs commented 7 years ago

It is good to have all has detection defined in one place for internal use. It is a minor refactoring.

codecov-io commented 7 years ago

Codecov Report

Merging #263 into master will increase coverage by -0.01%.

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
- Coverage   95.54%   95.53%   -0.01%     
==========================================
  Files          35       34       -1     
  Lines        1996     1993       -3     
  Branches      388      388              
==========================================
- Hits         1907     1904       -3     
  Misses         28       28              
  Partials       61       61

Impacted Files	Coverage Δ
src/request.ts	`89.04% <100%> (ø)`	:white_check_mark:
src/has.ts	`100% <100%> (ø)`	:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 99704af...6d1cc0e. Read the comment docs.

lzhoucs commented 7 years ago

I did a rebase. The new Codecov is being slightly confusing. I don't see how my change will decrease coverage. :)

Update: it turns out the Codecov data was out dated after I rebased it. The latest info is correct.

dylans commented 7 years ago

@lzhoucs go ahead and land it, thanks!

lzhoucs commented 7 years ago

@dylans , I don't think I have permission yet...

dojo / core

Clean up `has` module. #263

Codecov Report