search

dojo / core

:rocket: Dojo 2 - language helpers and utilities.
http://dojo.io
Other
213 stars 58 forks source link

Add canceler to `Task.all`, and tests. Issue #260. #274

Closed jacobroufa closed 7 years ago

jacobroufa commented 7 years ago

It looks like the Travis failures above are for an async test in Firefox and the text plugin on Android -- unrelated to the Task.all canceler. Is there anything I should do in this case?

dylans commented 7 years ago

Per discussion, let's squash and merge this as the CI failure is unrelated to these changes.

codecov-io commented 7 years ago

Codecov Report

Merging #274 into master will decrease coverage by 0.69%. The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #274     +/-   ##
=========================================
- Coverage   94.14%   93.44%   -0.7%     
=========================================
  Files          40       44      +4     
  Lines        2202     2792    +590     
  Branches      408      590    +182     
=========================================
+ Hits         2073     2609    +536     
- Misses         51       75     +24     
- Partials       78      108     +30
Impacted Files Coverage Δ
src/async/Task.ts 92.85% <83.33%> (-2.44%) :arrow_down:
src/queue.ts 93.54% <0%> (-6.46%) :arrow_down:
src/request.ts 91.95% <0%> (-4.93%) :arrow_down:
src/has.ts 95.45% <0%> (-4.55%) :arrow_down:
src/request/providers/node.ts 88.03% <0%> (-2.28%) :arrow_down:
src/request/providers/xhr.ts 85.81% <0%> (-1.85%) :arrow_down:
src/aspect.ts 95.67% <0%> (-0.57%) :arrow_down:
src/async/ExtensiblePromise.ts 100% <0%> (ø) :arrow_up:
src/lang.ts 100% <0%> (ø) :arrow_up:
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f777ae6...39fe3eb. Read the comment docs.

dylans commented 7 years ago

We should decide what to do with this one as it is getting stale.

kitsonk commented 7 years ago

IMO, Jason's comments appear to be valid and should be addressed.

jacobroufa commented 7 years ago

Feedback addressed in 39fe3eb. Please let me know if there's anything else on this one!

kitsonk commented 7 years ago

@maier49 we need to do whatever with this PR, either get it to pass the tests, resolve conflicts, whatever...

maier49 commented 7 years ago

@kitsonk I resolved the conflicts and resolved the last piece of feedback from Jason that wasn't already addressed. The build is still failing but that should be unrelated since master is failing and all of the task tests pass.