Closed kitsonk closed 7 years ago
Requires dojo/shim#80 to land first.
Let's re-export @dojo/shim/global
for now to cause the least amount of downstream breakage.
Merging #303 into master will decrease coverage by
-86.9%
. The diff coverage is0%
.
@@ Coverage Diff @@
## master #303 +/- ##
=========================================
- Coverage 93.86% 6.96% -86.9%
=========================================
Files 38 37 -1
Lines 2135 2124 -11
Branches 405 402 -3
=========================================
- Hits 2004 148 -1856
- Misses 52 1976 +1924
+ Partials 79 0 -79
Impacted Files | Coverage Δ | |
---|---|---|
src/main.ts | 0% <ø> (-100%) |
:x: |
src/request/providers/xhr.ts | 3.54% <0%> (-82.27%) |
:x: |
src/has.ts | 0% <0%> (-100%) |
:x: |
src/queue.ts | 0% <0%> (-100%) |
:x: |
src/MultiMap.ts | 1.07% <0%> (-98.93%) |
:x: |
src/DateObject.ts | 1.39% <0%> (-98.61%) |
:x: |
src/IdentityRegistry.ts | 3.17% <0%> (-96.83%) |
:x: |
src/request.ts | 0% <0%> (-96.16%) |
:x: |
src/encoding.ts | 0.67% <0%> (-95.98%) |
:x: |
src/Observable.ts | 3.84% <0%> (-94.88%) |
:x: |
... and 30 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b5f3b35...6bc588c. Read the comment docs.
This one is now stale and needs a rebase @kitsonk
Replaced with a different PR
Type: bug
The following has been addressed in the PR:
Description:
Removes global from core and uses
@dojo/shim/global
instead.Resolves #302