Closed mwistrand closed 7 years ago
Merging #305 into master will increase coverage by
<.01%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #305 +/- ##
==========================================
+ Coverage 93.86% 93.87% +<.01%
==========================================
Files 38 39 +1
Lines 2135 2138 +3
Branches 405 405
==========================================
+ Hits 2004 2007 +3
Misses 52 52
Partials 79 79
Impacted Files | Coverage Δ | |
---|---|---|
src/load/webpack.ts | 100% <100%> (ø) |
:white_check_mark: |
src/load.ts | 88.46% <100%> (-1.37%) |
:x: |
src/load/util.ts | 100% <100%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b5f3b35...48e0f21. Read the comment docs.
One question: should load
re-export isPlugin
and useDefault
since they were originally exports of load
, or is it fine to require others to import them from load/util
if needed?
@mwistrand we should re-export those functions from `loads.
Type: bug
The following has been addressed in the PR:
Description:
src/load/webpack
is no longer including the values imported fromsrc/load
in webpack builds. Separating the common methods between the two into a shared module circumvents this issue.Resolves #304