search

dojo / core

:rocket: Dojo 2 - language helpers and utilities.
http://dojo.io
Other
213 stars 62 forks source link

Fix for binary data getting corrupted in node request provider #315

Closed rorticus closed 7 years ago

rorticus commented 7 years ago

Type: bug / feature

The following has been addressed in the PR:

Description:

Binary data (a zip file in this case) was being corrupted in the node request provider because it would convert everything to a string and that was causing some issues.

Also explicitly ignoring the None content encoding.

codecov[bot] commented 7 years ago

Codecov Report

Merging #315 into master will increase coverage by 0.08%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #315      +/-   ##
==========================================
+ Coverage   93.88%   93.97%   +0.08%     
==========================================
  Files          39       39              
  Lines        2144     2142       -2     
  Branches      408      407       -1     
==========================================
  Hits         2013     2013              
+ Misses         52       51       -1     
+ Partials       79       78       -1
Impacted Files Coverage Δ
src/request/providers/node.ts 88.88% <66.66%> (+0.85%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a77d9e7...684ad61. Read the comment docs.

rorticus commented 7 years ago

CI build seems to have failed due to unrelated docs issue.