dojo / core

:rocket: Dojo 2 - language helpers and utilities.
http://dojo.io
Other
213 stars 62 forks source link

Has test for `blob` should use a valid URI #319

Closed agubler closed 7 years ago

agubler commented 7 years ago

Type: bug

The following has been addressed in the PR:

Description:

Update has check for blob to a valid URI.

Resolves #318

agubler commented 7 years ago

This is failing for typedoc, all other CI checks passed. Merging.

msssk commented 7 years ago

This should use an absolute URI, see https://github.com/dojo/dojo/pull/260.

It should also include a unit test like the one the PR linked above.

agubler commented 7 years ago

@msssk You're correct, it still doesn't work with /foo in a jsdom environment (i do not understand why it was working locally for me yesterday)