agubler commented 7 years ago

Type: feature

The following has been addressed in the PR:

[x] There is a related issue
[x] All code matches the style guide
[x] Unit or Functional tests are included in the PR

Description:

Adds support to use symbols as an event type.

As part of this PR I have moved interfaces from @dojo/interfaces that have been affected into the Evented module; It feels cumbersome to need to make interface changes in @dojo/interfaces (that could be breaking, which is pretty much unmanageable) and then release @dojo/interfaces in order to get make fixes/enhancements downstream.

Resolves #329

agubler commented 7 years ago

Needs some js documentation.

codecov[bot] commented 7 years ago

Codecov Report

Merging #330 into master will not change coverage. The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #330   +/-   ##
=======================================
  Coverage   93.97%   93.97%           
=======================================
  Files          39       39           
  Lines        2142     2142           
  Branches      407      407           
=======================================
  Hits         2013     2013           
  Misses         51       51           
  Partials       78       78

Impacted Files	Coverage Δ
src/on.ts	`92.3% <ø> (ø)`	:arrow_up:
src/QueuingEvented.ts	`96.87% <100%> (ø)`	:arrow_up:
src/Evented.ts	`100% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8a1d0ac...42b69c2. Read the comment docs.

dojo / core

Support symbols for event type #330

Codecov Report